fixed the use of the LinearTransformationSceneExample in Jupyter notebooks #3284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed from np.asarray(point) to nd.array(point) in order to make sure that a copy of the array is created even if func is the identity function lambda pos: pos
…ooks The Manim magic in Jupyter notebooks adds a "renderer=" parameter to the __init__ call of the scene, but in its current form the example scene LinearTransformationSceneExample does not accept any **kwargs and thus creates an exception. Added the handling of **kwargs in the example scene.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
In its current form the
LinearTransformationSceneExampledoes not allow any additional**kwargsin its__init__call, but Jupyter's Manim magic automatically adds arenderer=argument.I just added the
kwarg-handling which was missing from the example.Further Information and Comments
see LinearTransformationScene doesn't work? on Discord
Reviewer Checklist